linux-kernel - Re: [PATCH] hugetlb: Fix clear_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070928122318.57b99a0a.akpm@linux-foundation.org>
Date:	Fri, 28 Sep 2007 12:23:18 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] hugetlb: Fix clear_user_highpage arguments

On Fri, 28 Sep 2007 19:53:35 +0100 Ralf Baechle <ralf@...ux-mips.org> wrote:

> On Fri, Sep 28, 2007 at 11:45:26AM -0700, Andrew Morton wrote:
> 
> > 
> > > The virtual address space argument of clear_user_highpage is supposed to
> > > be the virtual address where the page being cleared will eventually be
> > > mapped. This allows architectures with virtually indexed caches a few
> > > clever tricks.  That sort of trick falls over in painful ways if the
> > > virtual address argument is wrong.
> > 
> > yeah, but only if you're using a weird CPU architecture ;)
> 
> I guess once I convinced your employer that weird CPU architectures
> deliver more punch for the watt they stop being so weird ;-)

<wonders what you've gone and done this time>

> > > 
> > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > > index 84c795e..eab8c42 100644
> > > --- a/mm/hugetlb.c
> > > +++ b/mm/hugetlb.c
> > > @@ -42,7 +42,7 @@ static void clear_huge_page(struct page *page, unsigned long addr)
> > >  	might_sleep();
> > >  	for (i = 0; i < (HPAGE_SIZE/PAGE_SIZE); i++) {
> > >  		cond_resched();
> > > -		clear_user_highpage(page + i, addr);
> > > +		clear_user_highpage(page + i, addr + i * PAGE_SIZE);
> > >  	}
> > >  }
> > >  
> > 
> > I'll add this to the 2.6.23 queue.  Is it needed in 2.6.22.x?
> 
> It's totally theoretical atm, MIPS doesn't support hugetlb and I'm not
> even working on it.  I just happened to spot the issue.

sparc64 might care about this bug.

Anyway, I'll plop it in 2.6.23.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/