linux-kernel - Re: PATCH [2/8] scsi: megaraid_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070928133218.e3f07a60.randy.dunlap@oracle.com>
Date:	Fri, 28 Sep 2007 13:32:18 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	bo yang <bo.yang@....com>
Cc:	linux-scsi@...r.kernel.org, James.Bottomley@...elEye.com,
	akpm@...l.org, linux-kernel@...r.kernel.org, Sumant.patro@....com
Subject: Re: PATCH [2/8] scsi: megaraid_sas - add module param fast_load

On Wed, 26 Sep 2007 11:22:10 -0400 bo yang wrote:

> Driver will skip physical devices scan for the first time if the fast_load is set. This is to reduce time for loading driver.
> 
> Signed-off-by: Bo Yang <bo.yang@....com>
> 
> ---
>  drivers/scsi/megaraid/megaraid_sas.c |   69 +++++++++++++++++++------
>  1 files changed, 55 insertions(+), 14 deletions(-)
> 
> diff -rupN linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c
> --- linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c	2007-09-26 16:19:18.321402040 -0400
> +++ linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c	2007-09-26 16:20:52.915021624 -0400
> @@ -46,6 +46,22 @@
>  #include <scsi/scsi_host.h>
>  #include "megaraid_sas.h"
>  
> +/*
> + * Module parameters
> + */
> +
> +/*
> + * Fast driver load option, skip scanning for physical devices during
> + * load.  This would result in physical devices being skipped during
> + * driver load time. These can be later added though,
> + * using /proc/scsi/scsi
> + */
> +static unsigned int fast_load;
> +module_param_named(fast_load, fast_load, int, 0);
> +MODULE_PARM_DESC(fast_load,
> +	"megasas: Faster loading of the driver, skips physical devices! \
> +	 (default = 0)");

The continuation line begins with an unwanted tab that is inside the
"string".  How about like this?  (untested)


MODULE_PARM_DESC(fast_load,
	"megasas: Faster loading of the driver, skips physical devices! "\
	"(default = 0)");


> +
>  MODULE_LICENSE("GPL");
>  MODULE_VERSION(MEGASAS_VERSION);
>  MODULE_AUTHOR("megaraidlinux@....com");


---
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/