[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fa686aa40709301633q32c7bd9epf07b5a78acb4380e@mail.gmail.com>
Date: Sun, 30 Sep 2007 17:33:55 -0600
From: "Grant Likely" <grant.likely@...retlab.ca>
To: "Christoph Hellwig" <hch@...radead.org>,
"Grant Likely" <grant.likely@...retlab.ca>,
linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
paulus@...ba.org, axboe@...nel.dk
Subject: Re: [PATCH v2 2/6] Sysace: Use the established platform bus api
On 9/30/07, Christoph Hellwig <hch@...radead.org> wrote:
> On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote:
> > + if ((rc = platform_driver_register(&ace_platform_driver)) != 0)
> > + goto err_plat;
>
> rc = platform_driver_register(&ace_platform_driver);
> if (rc)
> goto err_plat;
>
> please.
Okay, will do.
>
> > + err_plat:
> > + unregister_blkdev(ace_major, "xsysace");
> > + err_blk:
>
> labels should be indented zero or one space, but not more.
scripts/Lindent does this. Originally, I *didn't* have my labels
indented. :-) Does Lindent need to be fixed?
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists