linux-kernel - Re: [PATCH] robust futex thread exit race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070930151827.GB23127@elte.hu>
Date:	Sun, 30 Sep 2007 17:18:27 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Ulrich Drepper <drepper@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] robust futex thread exit race


* Martin Schwidefsky <schwidefsky@...ibm.com> wrote:

> Hi Ingo,
> I finally found the bug that causes tst-robust8 from the glibc to fail
> on s390x. Turned out to be a common code problem with the processing of
> the robust futex list. The patch below fixes the bug for me.

good catch! A quick preliminary review of your patch indicates it's fine 
- and it might be v2.6.23 material.

Acked-by: Ingo Molnar <mingo@...e.hu>

> Calling handle_futex_death in exit_robust_list for the different 
> robust mutexes of a thread basically frees the mutex. Another thread 
> might grab the lock immediately which updates the next pointer of the 
> mutex. fetch_robust_entry over the next pointer might therefore branch 
> into the robust mutex list of a different thread. This can cause two 
> problems: 1) some mutexes held by the dead thread are not getting 
> freed and 2) some mutexs held by a different thread are freed. The 
> next point need to be read before calling handle_futex_death.

nasty race... Ulrich, Thomas, do you concur?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/