linux-kernel - Re: [PATCH] PCI hotplug : Switch to pci_get_bus_and_slot instead of deprecated pci_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071001061025.GA11573@suse.de>
Date:	Sun, 30 Sep 2007 23:10:25 -0700
From:	Greg KH <gregkh@...e.de>
To:	JoonwooPark <joonwpark81@...il.com>
Cc:	linux-kernel@...r.kernel.org, kristen.c.accardi@...el.com
Subject: Re: [PATCH] PCI hotplug : Switch to pci_get_bus_and_slot instead
	of deprecated pci_find_slot.

On Mon, Oct 01, 2007 at 12:09:07PM +0900, JoonwooPark wrote:
> This patch fixes these warnings:
> 
> drivers/pci/hotplug/cpqphp_pci.c: In function ???cpqhp_configure_device???:
> drivers/pci/hotplug/cpqphp_pci.c:92: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> drivers/pci/hotplug/cpqphp_pci.c:102: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> drivers/pci/hotplug/cpqphp_pci.c: In function ???cpqhp_unconfigure_device???:
> drivers/pci/hotplug/cpqphp_pci.c:126: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> drivers/pci/hotplug/cpqphp_pci.c: In function ???cpqhp_save_config???:
> drivers/pci/hotplug/cpqphp_pci.c:420: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> 
> Signed-off-by: Joonwoo Park <joonwpark81@...il.com>

Close, but you need to free the reference that you now have grabed.  As
is, this patch will cause a memory leak and cause bad things to happen
:(

Take a look at the documentation for the pci_get_bus_and_slot()
function, it's not as easy as a simple search-and-replace.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/