lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1191295009.6310.55.camel@pasglop> Date: Tue, 02 Oct 2007 13:16:49 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Arnd Bergmann <arnd@...db.de> Cc: linuxppc-dev@...abs.org, linux-pci@...ey.karlin.mff.cuni.cz, paulus@...ba.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] powerpc: fix pci domain detection On Wed, 2007-09-26 at 16:02 +0200, Arnd Bergmann wrote: > The /proc/bus/pci/* files list PCI domain numbers only for > devices that claim to be on a multi-domain system. The check > for this is broken on powerpc, because the buid value is > truncated to 32 bits. > > There is at least one machine (IBM QS21) that only uses > the high-order bits of the buid, so the return value > of pci_proc_domain() ends up being always zero, which > makes /proc/bus/pci useless. > > Change the logic to always return '1' for a nonzero > buid value. > > Signed-off-by: Arnd Bergmann <arnd.bergmann@...ibm.com> Good catch ! Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org> > > diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c > index 291ffbc..9f63bdc 100644 > --- a/arch/powerpc/kernel/pci_64.c > +++ b/arch/powerpc/kernel/pci_64.c > @@ -588,7 +588,7 @@ int pci_proc_domain(struct pci_bus *bus) > return 0; > else { > struct pci_controller *hose = pci_bus_to_host(bus); > - return hose->buid; > + return hose->buid != 0; > } > } > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@...abs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists