linux-kernel - Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11826.1191328350@redhat.com>
Date:	Tue, 02 Oct 2007 13:32:30 +0100
From:	David Howells <dhowells@...hat.com>
To:	Zach Brown <zab@...bo.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	dhowells@...hat.com, Christoph Hellwig <hch@...radead.org>,
	viro@....linux.org.uk, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

Zach Brown <zab@...bo.net> wrote:

> /* haha, continuing the fine tradition of terrible names in this  api..  */
> static inline void *PTR_PTR(void *err_ptr) {
> 	BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
> 	return err_ptr;
> }

How about ERR_CAST() instead?  Or maybe CAST_ERR()?

	struct dentry *blah(...)
	{
		struct inode *inode;

		inode = thing(...);
		if (IS_ERR(inode))
			return ERR_CAST(inode);
	}

Where ERR_CAST is defined as:

	static inline void *ERR_CAST(const void *error)
	{
		return (void *) x;
	}

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/