linux-kernel - Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071003082157.GB32218@elte.hu>
Date:	Wed, 3 Oct 2007 10:21:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Bill Davidsen <davidsen@....com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org
Subject: Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..


* Mel Gorman <mel@....ul.ie> wrote:

> > > Nice one Ingo - got it first try. The problem commit was 
> > > dd41f596cda0d7d6e4a8b139ffdfabcefdd46528 and it's clear that the 
> > > code removed in this commit is put back by this latest patch.  
> > > When applied, profile=sleep works as long as CONFIG_SCHEDSTAT is 
> > > set.
> > > 
> > And if it isn't set? I can easily see building a new kernel with 
> > stats off and forgetting to change the boot options.
> 
> If CONFIG_SCHEDSTAT is off and profile=sleep is set, you see with 
> Ingo's patch and readprofile;
> 
>      0 *unknown*
>      0 total                                      0.0000
> 
> That is a tad confusing hence my follow-up patch which would say 
> "/proc/profile" doesn't exist when readprofile is used and the warning 
> in dmesg.

yep - that's the best we can do for the stable release.

We could improve quality of behavior here by not offering /proc/profile 
in that case and by printk-ing something if profile=sleep is specified 
on a !CONFIG_SCHEDSTATS kernel. I'm willing to apply patches that do 
that :)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/