[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20071003010225.GC26752@sgi.com>
Date: Tue, 2 Oct 2007 18:02:25 -0700
From: akepner@....com
To: Roland Dreier <rdreier@...co.com>
Cc: Grant Grundler <grundler@...isc-linux.org>,
Jesse Barnes <jbarnes@...tuousgeek.org>,
Jes Sorensen <jes@....com>,
Randy Dunlap <randy.dunlap@...cle.com>,
James Bottomley <James.Bottomley@...eleye.com>,
linux-kernel@...r.kernel.org
Subject: Re: [4/4] mthca: allow setting "dmabarrier" on user-allocated memory
On Fri, Sep 28, 2007 at 12:50:00PM -0700, Roland Dreier wrote:
> Sorry for not mentioning this earlier, but this patch should really be
> two (or more) patches: one to add dmabarrier support to the core user
> memory stuff in drivers/infiniband, and a second one to add support to
> mthca (and more patches to add support to mlx4, cxgb3, etc, etc).
Makes sense.
>
> > + * @dmabarrier: set "dmabarrier" attribute on this memory, if necessary
>
> Nit: just delete the "if necessary" since I don't think it makes
> things clearer (and actually doesn't make much sense in this context)
>
OK.
> Other than that this look fine to me, and I'm ready to merge it once
> the necessary core DMA stuff is settled.
>
Great. A new version of the patchset is on the way.
--
Arthur
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists