lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20071003103213.a1a94e70.randy.dunlap@oracle.com>
Date:	Wed, 3 Oct 2007 10:32:13 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	trivial@...nel.org
Subject: Re: [PATCH] DOC:  Correct explanations of "find_next" bit routines.

On Wed, 3 Oct 2007 09:18:39 -0400 (EDT) Robert P. J. Day wrote:

> 
> Correct the obvious "copy and paste" errors explaining some of the
> "find_next" routines.
> 
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

> ---
> 
>  arch/i386/lib/bitops.c    |    2 +-
>  arch/x86_64/lib/bitops.c  |    2 +-
>  include/asm-i386/bitops.h |    5 ++---
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/i386/lib/bitops.c b/arch/i386/lib/bitops.c
> index afd0045..b654404 100644
> --- a/arch/i386/lib/bitops.c
> +++ b/arch/i386/lib/bitops.c
> @@ -2,7 +2,7 @@
>  #include <linux/module.h>
> 
>  /**
> - * find_next_bit - find the first set bit in a memory region
> + * find_next_bit - find the next set bit in a memory region
>   * @addr: The address to base the search on
>   * @offset: The bitnumber to start searching at
>   * @size: The maximum size to search
> diff --git a/arch/x86_64/lib/bitops.c b/arch/x86_64/lib/bitops.c
> index 95b6d96..0e8f491 100644
> --- a/arch/x86_64/lib/bitops.c
> +++ b/arch/x86_64/lib/bitops.c
> @@ -58,7 +58,7 @@ long find_first_zero_bit(const unsigned long * addr, unsigned long size)
>  }
> 
>  /**
> - * find_next_zero_bit - find the first zero bit in a memory region
> + * find_next_zero_bit - find the next zero bit in a memory region
>   * @addr: The address to base the search on
>   * @offset: The bitnumber to start searching at
>   * @size: The maximum size to search
> diff --git a/include/asm-i386/bitops.h b/include/asm-i386/bitops.h
> index a20fe98..700b1a2 100644
> --- a/include/asm-i386/bitops.h
> +++ b/include/asm-i386/bitops.h
> @@ -1,4 +1,3 @@
> -#ifndef _I386_BITOPS_H
>  #define _I386_BITOPS_H
> 
>  /*
> @@ -297,7 +296,7 @@ static inline int find_first_zero_bit(const unsigned long *addr, unsigned size)
>  }
> 
>  /**
> - * find_next_zero_bit - find the first zero bit in a memory region
> + * find_next_zero_bit - find the next zero bit in a memory region
>   * @addr: The address to base the search on
>   * @offset: The bitnumber to start searching at
>   * @size: The maximum size to search
> @@ -340,7 +339,7 @@ static inline unsigned find_first_bit(const unsigned long *addr, unsigned size)
>  }
> 
>  /**
> - * find_next_bit - find the first set bit in a memory region
> + * find_next_bit - find the next set bit in a memory region
>   * @addr: The address to base the search on
>   * @offset: The bitnumber to start searching at
>   * @size: The maximum size to search
> -- 
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
> 
> http://crashcourse.ca
> ========================================================================
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ