lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Oct 2007 14:58:07 -0700 (PDT) From: David Miller <davem@...emloft.net> To: a.p.zijlstra@...llo.nl Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, shemminger@...ux-foundation.org, jdike@...toit.com Subject: Re: [PATCH] net: fix race in process_backlog From: Peter Zijlstra <a.p.zijlstra@...llo.nl> Date: Wed, 03 Oct 2007 17:44:53 +0200 > Index: linux-2.6/net/core/dev.c > =================================================================== > --- linux-2.6.orig/net/core/dev.c > +++ linux-2.6/net/core/dev.c > @@ -2095,11 +2095,11 @@ static int process_backlog(struct napi_s > > local_irq_disable(); > skb = __skb_dequeue(&queue->input_pkt_queue); > - local_irq_enable(); > if (!skb) { > - napi_complete(napi); > + __napi_complete(napi); > break; > } > + local_irq_enable(); What re-enables interrupts in the !skb path? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists