| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071002215316.0faa7676@freepuppy.rosehill> Date: Tue, 2 Oct 2007 21:53:16 -0700 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Jeff Garzik <jgarzik@...ox.com> Cc: pomac@...or.com, Linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] sky2: jumbo frame regression fix On Tue, 02 Oct 2007 21:07:22 -0400 Jeff Garzik <jgarzik@...ox.com> wrote: > Stephen Hemminger wrote: > > Remove unneeded check that caused problems with jumbo frame sizes. > > The check was recently added and is wrong. > > When using jumbo frames the sky2 driver does fragmentation, so > > rx_data_size is less than mtu. > > > > Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org> > > > > --- a/drivers/net/sky2.c 2007-10-02 17:56:31.000000000 -0700 > > +++ b/drivers/net/sky2.c 2007-10-02 17:58:56.000000000 -0700 > > @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru > > sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending; > > prefetch(sky2->rx_ring + sky2->rx_next); > > > > - if (length < ETH_ZLEN || length > sky2->rx_data_size) > > - goto len_error; > > - > > 2.6.23? 2.6.24? enquiring minds want to know... 2.6.23, since it is a regression -- Stephen Hemminger <shemminger@...ux-foundation.org> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists