linux-kernel - Re: -rt scheduling: wakeup bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071004080217.GE9176@elte.hu>
Date:	Thu, 4 Oct 2007 10:02:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Kravetz <kravetz@...ibm.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Clark Williams <williams@...hat.com>
Subject: Re: -rt scheduling: wakeup bug?


* Mike Kravetz <kravetz@...ibm.com> wrote:

> >  	if (rq->curr && p && rq && _need_resched())
> >  		trace_special_pid(p->pid, PRIO(p), PRIO(rq->curr));
> 
> Not an issue with the patch, just that last bit of code pulled in for 
> context.  I don't think it is a bug, but the checking of 'rq' after 
> checking 'rq->curr' just doesn't look right (or necessary).  Could it 
> just be an artifact from earlier versions of the code?

yeah, you are right - and rq shouldnt ever be NULL there anyway.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/