lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <47043351.2010708@zytor.com> Date: Wed, 03 Oct 2007 17:26:57 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Rusty Russell <rusty@...tcorp.com.au> CC: Chris Malley <mail@...ismalley.co.uk>, lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>, Jeremy Fitzhardinge <jeremy@...p.org>, lguest <lguest@...abs.org>, James Bottomley <James.Bottomley@...senPartnership.com>, Vivek Goyal <vgoyal@...ibm.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Stephen Rothwell <sfr@...b.auug.org.au> Subject: Re: [PATCH 5/5] lguest: loading bzImage directly Rusty Russell wrote: > On Wed, 2007-10-03 at 10:37 +0100, Chris Malley wrote: >> Hi guys >> >> Would it not be clearer to #include <asm/bootparam.h> and use >> the relevant named members of struct setup_header / struct boot_params >> rather than the hard-coded values 0x202, 0x1F1, 0x214 ? > > Yes, but unfortunately bootparam.h wasn't designed to be included from > userspace. > > The patch would look like this, but it makes me wonder if it'd be better > to put all these user-exposed types in bootparam.h and have the other > headers include them. hpa? > I don't have a strong preference either way, but I think what you have here is fine. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists