linux-kernel - [patch] reiser4: do not allocate struct file on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <470575AE.9060902@namesys.com>
Date:	Fri, 05 Oct 2007 03:22:22 +0400
From:	Edward Shishkin <edward@...esys.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	"Vladimir V. Saveliev" <vs@...sterfs.com>
CC:	Dave Hansen <haveblue@...ibm.com>, Zan Lynx <zlynx@....org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	reiserfs-devel <reiserfs-devel@...r.kernel.org>,
	hch <hch@...radead.org>
Subject: [patch] reiser4: do not allocate struct file on stack

Edward Shishkin wrote:

> Dave Hansen wrote:
>
...

>>
>> I think that stack allocation is a pretty nasty trick for a structure
>> that's supposed to be pretty persistent and dynamically allocated, and
>> is certainly something that needs to get fixed up in a proper way.
>>
>>
>
> agreed.
>
>> This works around the problem for now, but this could potentially cause
>> more bugs any time we add some member to 'struct file' and depend on its
>> state being sane anywhere in the VFS. If there's a list anywhere of
>> merge-stopper reiser4 bugs around, this should probably go in there.
>>
>>
>
> will be fixed.
>

The promised fixup is attached.
Andrew, please apply.

Thanks,
Edward.

View attachment "reiser4-fix-null-dereference-in-__mnt_is_readonly-in-ftruncate-2.patch" of type "text/x-patch" (5401 bytes)