[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071004013606.GA14755@askeshav-devel.jf.intel.com>
Date: Wed, 3 Oct 2007 18:36:07 -0700
From: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
akpm@...ux-foundation.org, Greg KH <greg@...ah.com>,
muli@...ibm.com, paulus@...ba.org, kristen.c.accardi@...el.com
Subject: Re: [patch take 2][Intel-IOMMU] Fix for IOMMU early crash
On Thu, Oct 04, 2007 at 11:19:33AM +1000, Benjamin Herrenschmidt wrote:
> > Index: 2.6-mm/include/linux/pci.h
> > ===================================================================
> > --- 2.6-mm.orig/include/linux/pci.h 2007-10-03 13:48:20.000000000 -0700
> > +++ 2.6-mm/include/linux/pci.h 2007-10-03 13:49:08.000000000 -0700
> > @@ -195,6 +195,7 @@
> > #ifdef CONFIG_PCI_MSI
> > struct list_head msi_list;
> > #endif
> > + void *iommu_private; /* hook for IOMMU specific extension */
> > };
>
> I'm not fan of this. That would imply that iommu stuff is specific to
> PCI or that sort of thing.
>
> Why don't you use the new struct dev_archdata mechanism ? That's what I
> use on powerpc to provide optional iommu linkage to any device in the
> system.
Good one. I will certainly try out your idea and will update the list
tomorrow.
-Anil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists