linux-kernel - Re: [PATCH] isofs: add +w bit for non-RR discs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0710051358440.13406@fbirervta.pbzchgretzou.qr>
Date:	Fri, 5 Oct 2007 13:59:42 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Matthew Wilcox <matthew@....cx>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] isofs: add +w bit for non-RR discs


On Oct 4 2007 20:46, Matthew Wilcox wrote:
>On Tue, Oct 02, 2007 at 08:00:26PM +0200, Jan Engelhardt wrote:
>> Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge
>
>Looks to me like you've added S_IWUSR, not S_IWUGO.

Yes, S_IWUSR it should be, and is. When a user copies such a file,
the new file will be owned by him/her, so the +w bit needs to
be S_IWUSR indeed.

>> -	popt->mode = S_IRUGO | S_IXUGO; /*
>> +	popt->mode = S_IRUGO | S_IWUSR | S_IXUGO;
>> -		inode->i_mode = S_IRUGO | S_IXUGO | S_IFDIR;
>> +		inode->i_mode = S_IRUGO | S_IWUSR | S_IXUGO | S_IFDIR;
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/