linux-kernel - Re: [PATCH 1/1] unify DMA_..BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071005152450.a7652b75.akpm@linux-foundation.org>
Date:	Fri, 5 Oct 2007 15:24:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	schwab@...e.de, rpjday@...dspring.com, bbpetkov@...oo.de,
	linux-kernel@...r.kernel.org, muli@...ibm.com,
	satyam@...radead.org, amitkale@...xen.com,
	achim_leubner@...ptec.com
Subject: Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1

On Fri, 05 Oct 2007 14:28:45 -0700
Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Andreas Schwab wrote:
> > #define DMA_BIT_MASK(n)         ((u64)-1 >> (64 - (n)))
> >   
> 
> Yeah, that's cleaner.
> 

Well yes, but DMA_BIT_MASK(0) invokes undefined behaviour, generates a
compiler warning and evaluates to 0xffffffffffffffff (with my setup).

That won't be a problem in practice, but it is strictly wrong and doesn't set
a good exmaple for the children ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/