linux-kernel - Re: [RFC][PATCH] New message-logging API (kprint)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071008082541.2638bb34@freepuppy.rosehill>
Date:	Mon, 8 Oct 2007 08:25:41 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Rob Landley <rob@...dley.net>
Cc:	"Vegard Nossum" <vegard.nossum@...il.com>,
	"Miguel Ojeda" <maxextreme@...il.com>,
	"Randy Dunlap" <randy.dunlap@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Kyle Moffett" <mrmacman_g4@....com>,
	"Michael Holzheu" <holzheu@...ux.vnet.ibm.com>,
	"Joe Perches" <joe@...ches.com>,
	"Dick Streefland" <dick.streefland@...ium.nl>,
	"Geert Uytterhoeven" <Geert.Uytterhoeven@...ycom.com>,
	"Jesse Barnes" <jesse.barnes@...el.com>,
	"Arnd Bergmann" <arnd@...db.de>,
	"Jan Engelhardt" <jengelh@...putergmbh.de>,
	"Emil Medve" <Emilian.Medve@...escale.com>,
	"linux@...izon.com" <linux@...izon.com>
Subject: Re: [RFC][PATCH] New message-logging API (kprint)

On Sun, 7 Oct 2007 16:50:49 -0500
Rob Landley <rob@...dley.net> wrote:

> On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote:
> > On 10/5/07, Rob Landley <rob@...dley.net> wrote:
> > > The original idea (selectively compile out printk() instances based on
> > > log level to conserve space) is explicitly not addressed by this patch,
> > > and in fact this patch might actually make it harder to implement (by
> > > complicating the code).
> >
> > This is wrong. The patch provides log-level-based filtering at compile
> > time, effectively making the kernel smaller.
> 
> I made it about halfway through the patch and the only compile time filtering 
> I found was:
> 
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -62,7 +62,10 @@
>  #define MdpMinorShift 6
>  
>  #define DEBUG 0
> -#define dprintk(x...) ((void)(DEBUG && printk(x)))
> +#define dprintk(x...)          \
> +       if(DEBUG) {             \
> +                printk(x);     \
> +       }
> 
> If you say it does, I'll take your word for it, but there's so much churn in 
> there I didn't find it before my interest ran out...
> 

BTW that change might actually break code (dangling else problems).  
The original way was safer.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/