linux-kernel - Re: RFC: reviewer's statement of oversight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 08 Oct 2007 20:34:47 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Jan Engelhardt <jengelh@...putergmbh.de>,
	Sam Ravnborg <sam@...nborg.org>,
	Jonathan Corbet <corbet@....net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: RFC: reviewer's statement of oversight

Randy Dunlap wrote:
> On Mon, 08 Oct 2007 11:01:49 -0700 Jeremy Fitzhardinge wrote:
>> Tested-by is more valuable than acked-by, because its empirical. 
>> Acked-by generally means "I don't generally object to the idea of the
>> patch, but may not have read beyond the changelog".  Tested-by implies
>> "I did something that exercised the patch, and it didn't explode" -
>> that's on par with an actual review (ideally all patches would be both
>> tested and reviewed).
> 
> but Tested-by: doesn't have to involve any "actually looking at/reading
> the patch."  Right?
> 
> IOW, the patch could be ugly as sin but it works...

Tested-by translated into German and back into English:  "Works for me,
test methods not specified."

So, putting a Tested-by into the changelog is only useful if the
necessary testing is rather simple (i.e. "fixed the bug which I was
always able to reproduce before") or if the tester is known to have
performed rigorous and sufficiently broad tests.
-- 
Stefan Richter
-=====-=-=== =-=- -=---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/