[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <32082.1191870532@lwn.net>
Date: Mon, 08 Oct 2007 13:08:52 -0600
From: corbet@....net (Jonathan Corbet)
To: Al Viro <viro@....linux.org.uk>
Cc: mgross@...ux.intel.com, Stefan Richter <stefanr@...6.in-berlin.de>,
linux-kernel@...r.kernel.org
Subject: Re: RFC: reviewer's statement of oversight
Al Viro <viro@....linux.org.uk> wrote:
> > A patch which is not "worthwhile" is also not "appropriate". Mere
> > correctness in a mathematical sense is not enough as technical review
> > criterion.
>
> Yes, but there's also such thing as "worthwhile removal".
Good point. So the text should probably say "worthwhile change" rather
than "worthwhile addition." I do believe that thinking about whether
the change as a whole is a desirable thing is an important part of the
review process.
jon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists