linux-kernel - Re: RFC: reviewer's statement of oversight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b69d1470710081235q3c2fce20sbe41dd3e66def1a0@mail.gmail.com>
Date:	Mon, 8 Oct 2007 14:35:11 -0500
From:	"Scott Preece" <sepreece@...il.com>
To:	"Jan Engelhardt" <jengelh@...putergmbh.de>
Cc:	"Sam Ravnborg" <sam@...nborg.org>,
	"Jonathan Corbet" <corbet@....net>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Pekka Enberg" <penberg@...helsinki.fi>
Subject: Re: RFC: reviewer's statement of oversight

On 10/8/07, Jan Engelhardt <jengelh@...putergmbh.de> wrote:
>
> On Oct 8 2007 19:37, Sam Ravnborg wrote:
> >snip...
> >Acked-by:
> >Tested-by:
>
> * Used by random people to express their (dis)like/experience with the
> patch.
>
> >Reviewed-by:
>
> * I am maintaner or an 'important' person and have had a
>   look at it in depth
---

A couple of months ago there was a thread about Acked-by. At that time
the consensus seemed to be that it was inappropriate for random people
to add Acked-by - that it should only be added by people whose opinion
was expected to a gate for merging. Did the Summit reach a decision
that Acked-by was for anybody and Reviewed-by was for authorities?

I like Randy's point - the assigning of weight to the Reviewer's
opinion is necessarily in the hands of those at the top of the merge
process and there's no need to ask reviewers to decide whether their
opinion matters. In that view, "Acked-by" means "I have no objection
to this patch, but don't claim deep review" and "Reviewed-by" means "I
have no objection to this patch after a thorough review", and either
can be attached by anybody who wants to express an opinion.

scott
-- 
scott preece
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/