[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20071008224128.2EAAB65008@smtp.gentoo.org>
Date: Mon, 8 Oct 2007 22:41:28 +0000 (UTC)
From: Maarten Bressers <mbres@...too.org>
To: akpm@...ux-foundation.org
Cc: dsd@...too.org
Subject: [PATCH] Correct Makefile rule for generating custom keymap.
When building a custom keymap, after setting GENERATE_KEYMAP := 1 in
drivers/char/Makefile, the kernel build fails like this:
CC drivers/char/vt.o
make[2]: *** No rule to make target `drivers/char/%.map', needed by
`drivers/char/defkeymap.c'. Stop.
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2
This was caused by commit af8b128719f5248e542036ea994610a29d0642a6,
which deleted a necessary colon from the Makefile rule that generates
the keymap, since that rule contains both a target and a target-pattern.
The following patch puts the colon back:
Signed-off by: Maarten Bressers <mbres@...too.org>
--- a/drivers/char/Makefile 2007-10-08 23:46:47.000000000 +0200
+++ b/drivers/char/Makefile 2007-10-08 23:46:57.000000000 +0200
@@ -129,7 +129,7 @@ $(obj)/defkeymap.o: $(obj)/defkeymap.c
ifdef GENERATE_KEYMAP
-$(obj)/defkeymap.c $(obj)/%.c: $(src)/%.map
+$(obj)/defkeymap.c: $(obj)/%.c: $(src)/%.map
loadkeys --mktable $< > $@...p
sed -e 's/^static *//' $@...p > $@
rm $@...p
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists