linux-kernel - Re: Patch for WindowsMobile5 on Linux Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1191929103.10858.59.camel@xbox360>
Date:	Tue, 09 Oct 2007 13:25:03 +0200
From:	Thomas Sailer <t.sailer@...mni.ethz.ch>
To:	Xavier Bestel <xavier.bestel@...e.fr>
Cc:	Bernd Petrovitsch <bernd@...mix.at>,
	"Grosjo.net - jom" <jom@...sjo.net>, linux-kernel@...r.kernel.org
Subject: Re: Patch for WindowsMobile5 on Linux Kernel

On Tue, 2007-10-09 at 11:37 +0200, Xavier Bestel wrote:

> FWIW, the patch in question is a one-liner:

That's not a valid argument. This may work with a WM5 device, but looks
very dubious, wrt. other RNDIS devices. Why are these constants
hardcoded and not taken in some way from the descriptors?

There must be some justification why these values need to be hardcoded,
and if so, this must be dependent on the rndis device really being a WM5
device.

Nacked-By: Thomas Sailer <t.sailer@...mni.ethz.ch>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/