linux-kernel - Re: [PATCH -mm] slub: fix cpu hotplug offline/online path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Oct 2007 11:46:14 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Akinobu Mita <akinobu.mita@...il.com>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -mm] slub: fix cpu hotplug offline/online path

On Wed, 10 Oct 2007, Akinobu Mita wrote:

> This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
> call it for each possible CPUs not only online CPUs at initialization time.

Could you check if a per cpu structure has already been allocated and then 
simply skip the call to init? Otherwise we end up with lots of per cpu 
structures for cpus that will never show up. 

if (!get_cpu_slab(s, cpu))
	init_alloc_cpu_cpu( ...)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/