[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0710091212350.1812@schroedinger.engr.sgi.com>
Date: Tue, 9 Oct 2007 12:15:58 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Pekka Enberg <penberg@...helsinki.fi>
cc: Akinobu Mita <akinobu.mita@...il.com>,
linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>, travis@....com
Subject: Re: [PATCH -mm] slub: fix cpu hotplug offline/online path
On Tue, 9 Oct 2007, Pekka Enberg wrote:
> Hi Christoph,
>
> On 10/9/07, Christoph Lameter <clameter@....com> wrote:
> > Our system come by default with the possibility of 1k cpus. However, a
> > small system may only have 8 cpus.
>
> Maybe I am reading the code wrong, but I don't why that matters as
> it's all statically allocated anyway (the per-cpu kmem_cache_cpu
> array). In any case, I certainly don't object to your proposal, just
> can't figure out why it matters.
The kmem_cache_cpu structures are allocated using DEFINE_PER_CPU.
The per cpu areas should be dynamically allocated as necessary. There is
work in progress by Mike Travis to do that. You are right in that (on
x86_64 at least) we define a static array for all processors.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists