linux-kernel - Re: [PATCH v4] IBM power meter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071009204037.GF16003@tree.beaverton.ibm.com>
Date:	Tue, 9 Oct 2007 13:40:37 -0700
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org,
	haveblue@...ibm.com
Subject: Re: [PATCH v4] IBM power meter driver

On Tue, Oct 09, 2007 at 06:44:07PM +0200, Roel Kluin wrote:

> >> +	if (IS_ERR(data->hwmon_dev)) {
> >> +		printk(KERN_ERR DRVNAME ": Error, unable to register hwmon "
> >> +		       "class device for interface %d\n",
> >> +		       data->interface);
> >> +		kfree(data);
> >> +		return;
> 
> don't you want to goto out_user here instead?

Err, yes, thank you for catching that.

--D
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/