linux-kernel - Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710091719.23265.rob@landley.net>
Date:	Tue, 9 Oct 2007 17:19:23 -0500
From:	Rob Landley <rob@...dley.net>
To:	"Ahmed S. Darwish" <darwish.07@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	rdunlap@...otime.net
Subject: Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

On Tuesday 09 October 2007 8:03:15 am Ahmed S. Darwish wrote:
> $ man getcwd
>
>  char *getcwd(char *buf, size_t size);
>
>  As an extension to the POSIX.1 standard, Linux (libc4, libc5, glibc)
> getcwd() allocates the buffer dynamically using malloc() if buf is NULL on
> call.
>
> Shouldn't "srctree" be free()ed in case getenv("SRCTREE") failed ?

If exit() doesn't free all the memory the program allocated, we have bigger 
problems.

> Regards,

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/