linux-kernel - Re: [PATCH] usb: Key codes for Microsoft Natural Ergonomic 4000 USB keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2007 09:52:01 +1000
From:	John Zaitseff <J.Zaitseff@....org.au>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	linux-usb-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: Key codes for Microsoft Natural Ergonomic 4000 USB keyboard

Dear Jiri,

On Wed, Oct 10, 2007 at 09:55:26AM +0200, Jiri Kosina wrote:
> On Wed, 10 Oct 2007, John Zaitseff wrote:
> 
> > The following patch to Linux kernel 2.6.23 enables most of the
> > extra keys found on the Microsoft Natural Ergonomic 4000 USB
> > keyboard.  I had to add one keycode to include/linux/input.h;
> > feel free to reallocate the ID assigned to it (KEY_SPELL).
> 
> thanks a lot for the patch!  However I think I have already added
> all the needed support for this keyboard.  It is currently in my
> tree, queued until Linus opens the merge window for 2.6.24.
> Please look at
> http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=0f48b3ce23a34dbe70dcd04b4216fbcb965ab906
> 
> Commit 945bcc3a in the same branch is also related.

Excellent!  However, I don't see the following:

* case 0x182: map_key_clear(KEY_FAVORITES);
  ... in drivers/usb/input/hid-input.c, to handle the My Favorites key

* the change to drivers/hid/usbhid/usbkbd.c to enable the "(" and
  ")" on the right hand side of the keyboard

Have these already been included elsewhere?

Yours truly,

John Zaitseff

-- 
John Zaitseff                    ,--_|\    The ZAP Group
Phone:  +61 2 9643 7737         /      \   Sydney, Australia
E-mail: J.Zaitseff@....org.au   \_,--._*   http://www.zap.org.au/
                                      v
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/