linux-kernel - Re: [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Oct 2007 10:18:26 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Olof Johansson <olof@...om.net>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg KH <greg@...ah.com>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	linuxppc-dev@...abs.org, paulus@...ba.org, tgall.foo@...il.com,
	Thomas Gleixner <tglx@...utronix.de>, stable@...nel.org
Subject: Re: [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries

Hi Olof,

On Tue, 9 Oct 2007 19:08:15 -0500 Olof Johansson <olof@...om.net> wrote:
>
> Don't allow cpu hotplug on systems lacking XICS interrupt controller,
> since current platform code is hardcoded for it.
> 
> 
> Signed-off-by: Olof Johansson <olof@...om.net>
> 
> 
> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> index 9711eb0..e29b890 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> @@ -252,6 +252,19 @@ static struct notifier_block pseries_smp_nb = {
>  
>  static int __init pseries_cpu_hotplug_init(void)
>  {
> +	struct device_node *np;
> +	const char *typep;
> +
> +	for (np = NULL; (np = of_find_node_by_name(np,
> +						   "interrupt-controller"));) {
> +		typep = of_get_property(np, "compatible", NULL);
> +		if (strstr(typep, "open-pic")) {
> +			printk(KERN_INFO "CPU Hotplug not supported on "
> +				"systems using MPIC\n");

You need an of_node_put(np) here.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped