linux-kernel - Re: [PATCH] Make m68k cross compile like every other architecture.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710110827.12631.rob@landley.net>
Date:	Thu, 11 Oct 2007 08:27:12 -0500
From:	Rob Landley <rob@...dley.net>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux/m68k <linux-m68k@...r.kernel.org>
Subject: Re: [PATCH] Make m68k cross compile like every other architecture.

On Thursday 11 October 2007 7:46:47 am Geert Uytterhoeven wrote:
> On Thu, 11 Oct 2007, Sam Ravnborg wrote:
> > On Thu, Oct 11, 2007 at 09:25:19AM +0200, Geert Uytterhoeven wrote:
> > > On Wed, 10 Oct 2007, Rob Landley wrote:
> > > > From: Rob Landley <rob@...dley.net>
> > > >
> > > > Rip out hardwired cross compiler name assumption that only m68k
> > > > makes.
> > > >
> > > > Signed-off-by: Rob Landley <rob@...dley.net>
> > > > ---
> > > > When you cross compile, you have to set the prefix CROSS_COMPILE to
> > > > your cross compiler prefix.  You need to do this for all targets
> > > > (arm, mips, ppc, x86-64 on x86, etc).  This is not specific to m68k,
> > > > and this value is supplied _to_ the build, not supplied _by_ the
> > > > build.
> > > >
> > > > The build shouldn't unconditionally overwrite the existing value of
> > > > this variable with one it makes up.  It has no idea what I called my
> > > > cross compiler.
> > >
> > > The build does not unconditionally overwrite the existing value of this
> > > variable. You can specify the name of your cross compiler like this:
> > >
> > >     make CROSS_COMPILE=m68k-linux-
> > >
> > > BTW, m68k-linux-gnu- is the default name for a m68k cross compiler.
> >
> > For "make headers_install" this is not good.
> > But I see there is confliting usages here.
> > 1) current functionality makes it easy to build a cross compiled m68k
> >
> > Btw. if you did:
> > CROSS_COMPILE ?= m68k-linux-
> >
> > then I could do:
> > export CROSS_COMPILE=my-m68k-linux-
> > make
> >
> > and still get the expected result.
>
> That won't work, cfr. http://lkml.org/lkml/2007/5/6/58.

Reading the patch in that link, recent cross compilers from _where_?  
Buildroot?  Cross-tools?  Gentoo embedded?  Cross Linux From Scratch?  My 
Firmware Linux project?

You assume they all use the same name, yet your patch changes them from one 
default name to another default name, presumably due to a gcc version change 
becoming increasingly political about the GNU/Linux/Dammit thing...

None of the other targets I've tried attempt to _supply_ a default.  Just like 
the Linux kernel errors out early in the build if you distclean and then try 
to run "make" without having run config first.  It doesn't run "defconfig" 
for you and continue on in that case.  But m68k, uniquely, assumes it knows 
what you want to do when you didn't tell it.  Other targets do not do this.

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/