linux-kernel - Re: Scsi on sparc build break in 2.6.23.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2007 08:30:38 -0500
From:	James Bottomley <James.Bottomley@...elEye.com>
To:	Rob Landley <rob@...dley.net>
Cc:	Adrian Bunk <bunk@...nel.org>, linux-scsi@...r.kernel.org,
	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: Scsi on sparc build break in 2.6.23.

On Thu, 2007-10-11 at 08:17 -0500, Rob Landley wrote:
> On Thursday 11 October 2007 6:05:55 am Adrian Bunk wrote:
> > On Thu, Oct 11, 2007 at 05:52:48AM -0500, Rob Landley wrote:
> > > CONFIG_SCSI_SUNESP=y breaks the build in 2.6.23:
> > >
> > >   LD      vmlinux
> > > `scsi_esp_unregister' referenced in section `__ksymtab' of
> > > drivers/built-in.o: defined in discarded section `.exit.text' of
> > > drivers/built-in.o
> > > make: *** [vmlinux] Error 1
> > >
> > > Do you need my full .config to reproduce this?
> >
> > Please always attach the .config when reporting errors.
> > The few bytes don't matter and it often saves some time.
> >
> > I have an idea regarding what might be going wrong in this case,
> > but it would cost me additional time to look at it because you didn't
> > send your .config.
> 
> *shrug*  That's why I asked.
> 
> The reason I hesitated is I use miniconfig files rather than big .config 
> files, and some people get confused by that.  Drop the attached 
> miniconfig-linux in the kernel source directory and go:
>   make ARCH=sparc allnoconfig KCONFIG_ALLCONFIG=miniconfig-linux
> 
> That expands it to a big .config file, and from there "make ARCH=sparc 
> CROSS_COMPILE=sparc-" to reproduce the problem.  Assuming you have a sparc 
> cross-compiler lying around.
> 
> Disable CONFIG_SCSI_SUNESP and it builds to the end, (and the result boots but 
> won't mount the root filesystem, which is sort of expected).

This is a very subtle error.  You're building without hotplug, which
causes __devexit to become __exit, so scsi_esp_unregister is placed in
the discard section of vmlinux.  Unfortunately, the EXPORT_SYMBOL causes
it to be referenced from the symbol export table.

The fix is probably just to remove the __devexit tag from the function
rather than trying to work out how to make the export symbol conditional
on the symbol not being discarded.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/