linux-kernel - Re: [PATCH] RT: fix spin_trylock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0710111046170.20114@gandalf.stny.rr.com>
Date:	Thu, 11 Oct 2007 10:49:14 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Sébastien Dugué <sebastien.dugue@...l.net>
cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Linux RT Users <linux-rt-users@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Daniel Walker <dwalker@...sta.com>
Subject: Re: [PATCH] RT: fix spin_trylock_irq



--
When I'm asked what language is my mother tongue,
I simply answer "C".

On Thu, 11 Oct 2007, [UTF-8] Sébastien Dugué wrote:

> ---
>  include/linux/spinlock.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-rc9-rt2/include/linux/spinlock.h
> ===================================================================
> --- linux-2.6.23-rc9-rt2.orig/include/linux/spinlock.h
> +++ linux-2.6.23-rc9-rt2/include/linux/spinlock.h
> @@ -501,7 +501,7 @@ do {									\
>
>  #define spin_trylock_irq(lock)	\
>  	__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irq,		\
> -		__spin_trylock_irq, lock))
> +		_spin_trylock_irq, lock))
>
>  #define spin_trylock_irqsave(lock, flags) \
>  	__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irqsave, 	\

Thanks! Applied.

Daniel, this BUG was introduced by your conversion to PICK_FUNCTION patch.
Please be more careful, and do an audit of your patch. (I don't have time
ATM). This could also be the source of other bugs I've been chasing.

I might be pulling the PICK_FUNCTION patches if there's more bugs like
this.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/