linux-kernel - Re: [PATCH v2] cpuset sched_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071010201008.50854faf.pj@sgi.com>
Date:	Wed, 10 Oct 2007 20:10:08 -0700
From:	Paul Jackson <pj@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	dino@...ibm.com, cpw@....com, menage@...gle.com,
	linux-kernel@...r.kernel.org, randy.dunlap@...cle.com,
	nickpiggin@...oo.com.au, mingo@...e.hu
Subject: Re: [PATCH v2] cpuset sched_load_balance flag

> > +		doms = kmalloc(sizeof(cpumask_t), GFP_KERNEL);
> > +		*doms = top_cpuset.cpus_allowed;
> 
> We generally only excuse failure to check kmalloc return value when the
> code is called on the bootup path.  But this code is called at other times.
> 
> >
> > ...
> > +	doms_cur =  kmalloc(sizeof(cpumask_t), GFP_KERNEL);

Ah - good catch - thanks, Andrew.  I should put together a fix,
to check these kmalloc calls.

For rebuild_sched_domains(), this can mean we just up and return having
done nothing.

For arch_init_sched_domains(), the code calling arch_init_sched_domains()
is not checking for failure, and doesn't have a trivial fallback code
path in the case of failure.  I'll have to think about that one just a
little.

Thanks, Andrew!

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/