lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Oct 2007 11:50:12 -0400 From: "Dmitry Torokhov" <dmitry.torokhov@...il.com> To: bryan.wu@...log.com Cc: linux-input@...ey.karlin.mff.cuni.cz, linux-joystick@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org Subject: Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver On 10/12/07, Bryan Wu <bryan.wu@...log.com> wrote: > On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: > > Hi Bryan, > > > > On 10/12/07, Bryan Wu <bryan.wu@...log.com> wrote: > > > + > [snip] > > > + > > > +static void ad7142_close(struct input_dev *dev) > > > +{ > > > + free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX, ad7142_interrupt); > > > + kthread_stop(ad7142_task); > > > > Don't you need to write something over i2c to shut the devoce off? > > What stops it from continuing to generate interrupts? > > > Actually, I am going to use "completion" to replace the whole > wait_interrupt_xxx and intr_flag things which original from Aubrey. How > do you think of that? > I don't think it is a very good idea - for me completion is one-time deal. You use it and then you are done. How about firing a work from interrupt and either rely on the default workqueue (keventd) or create your own to execute it? Thank you. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists