lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200710112326.34500.david-b@pacbell.net>
Date:	Thu, 11 Oct 2007 23:26:34 -0700
From:	David Brownell <david-b@...bell.net>
To:	Bryan Wu <bryan.wu@...log.com>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH 02/10] Blackfin SPI driver: use new GPIO API and add error handling

On Thursday 11 October 2007, Bryan Wu wrote:
> @@ -1182,12 +1198,9 @@ static int __init bfin5xx_spi_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>         }
>  
> -       if (peripheral_request(P_SPI0_SCK, DRV_NAME) ||
> -                peripheral_request(P_SPI0_MISO, DRV_NAME) ||
> -                peripheral_request(P_SPI0_MOSI, DRV_NAME) ) {
> -
> +       if (setup_pin_mux(1)) {
>                 dev_err(&pdev->dev, ": Requesting Peripherals failed\n");
> -               goto out_error_queue_alloc;
> +               goto out_error;
>         }
>  
>         drv_data = spi_master_get_devdata(master);
> 

Still doesn't apply ... what tree are you generating this series against??
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ