linux-kernel - Re: [PATCH] hiddev: Add 32bit ioctl compatibilty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071013000221.GC8181@ftp.linux.org.uk>
Date:	Sat, 13 Oct 2007 01:02:21 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Philip Langdale <philipl@...rt.org>
Cc:	Jiri Kosina <jkosina@...e.cz>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hiddev: Add 32bit ioctl compatibilty

On Fri, Oct 12, 2007 at 04:51:00PM -0700, Philip Langdale wrote:
> The hiddev driver currently lacks 32bit ioctl compatibility, so
> if you're running with a 64bit kernel and 32bit userspace, it won't
> work.
> 
> I'm pretty sure that the only thing missing is a compat_ioctl
> implementation as all structs have fixed size fields.
> 
> +static long hiddev_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> +{
> +	struct inode *inode = file->f_path.dentry->d_inode;
> +	return hiddev_ioctl(inode, file, cmd, compat_ptr(arg));
> +}

Just how many instances of that sucker do we need?  It's nothing but

     struct inode *inode = file->f_path.dentry->d_inode;
     return file->f_op->ioctl(inode, file, cmd, compat_ptr(arg));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/