linux-kernel - Re: 2.6.23-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64bb37e0710130813le68c48dve36f8473b197b84b@mail.gmail.com>
Date:	Sat, 13 Oct 2007 17:13:00 +0200
From:	"Torsten Kaiser" <just.for.lkml@...glemail.com>
To:	"Jeff Garzik" <jeff@...zik.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	"Kuan Luo" <kluo@...dia.com>, "Peer Chen" <pchen@...dia.com>
Subject: Re: 2.6.23-mm1

On 10/13/07, Torsten Kaiser <just.for.lkml@...glemail.com> wrote:
> Wait!
>
> I think I found the bug: Its a evil interaction between the above
> patch and the swncq patch that is applied later.
> The qc_defer patch removes the old ata_scmd_need_defer that was always
> called for all drivers and substitutes it for ata_std_qc_defer and
> adds it as aops->qc_defer to all drivers that support NCQ *at that
> point*.
> Then the swncq patch adds a new NCQ capable driver, but the nobody
> added the qc_defer-ops to the ops-structure that is added. So swncq
> will never defer any commands and the first command that would need to
> be defered (the SMART commands) blows up, if there is still another
> command in flight.
>
> I will only add the qc_defer and try this...

3 boots, all worked. So I'm very sure that was the bug, but I will now
do a little load testing...

The only strange thing about 2.6.23-mm1 is, that it takes ~4 second
more to boot.

2.6.23-rc8-mm1:
[    3.720000] scsi0 : sata_sil24
[    3.730000] scsi1 : sata_sil24
[    3.740000] ata1: SATA max UDMA/100 irq 17
[    3.750000] ata2: SATA max UDMA/100 irq 17
[    4.110000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[    4.160000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    4.180000] ata1.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    4.240000] ata1.00: configured for UDMA/100
[    4.600000] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[    4.660000] ata2.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    4.680000] ata2.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    4.730000] ata2.00: configured for UDMA/100

2.6.23-mm1:
[    3.650000] scsi0 : sata_sil24
[    3.660000] scsi1 : sata_sil24
[    3.660000] ata1: SATA max UDMA/100 host m128@...feffc00 port
0xefef8000 irq 17
[    3.690000] ata2: SATA max UDMA/100 host m128@...feffc00 port
0xefefa000 irq 17
[    5.930000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 0)
[    5.980000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    6.000000] ata1.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    6.060000] ata1.00: configured for UDMA/100
[    8.290000] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 0)
[    8.340000] ata2.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    8.360000] ata2.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    8.420000] ata2.00: configured for UDMA/100

Torsten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/