linux-kernel - Re: 2.6.23-mm1 thread exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071013104943.e4a54abe.akpm@linux-foundation.org>
Date:	Sat, 13 Oct 2007 10:49:43 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	viro@....linux.org.uk, kamezawa.hiroyu@...fujitsu.com,
	linux-kernel@...r.kernel.org, sam@...nborg.org,
	netdev@...r.kernel.org, Pavel Emelyanov <xemul@...nvz.org>,
	Sukadev Bhattiprolu <sukadev@...ibm.com>,
	Paul Menage <menage@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: 2.6.23-mm1 thread exit_group issue

On Sat, 13 Oct 2007 16:02:30 +0400 Oleg Nesterov <oleg@...sign.ru> wrote:

> On 10/13, Oleg Nesterov wrote:
> >
> > On 10/12, Andrew Morton wrote:
> > >
> > > Bisection shows that this problem is caused by these two patches:
> > >
> > > pid-namespaces-allow-cloning-of-new-namespace.patch
> > 
> > This? http://marc.info/?l=linux-mm-commits&m=118712242002039
> > 
> > Pavel, this patch has a subtle difference compared to what we discussed on
> > containers list. It moves put_user(parent_tidptr) from copy_process() to
> > do_fork(), so we don't report child's pid if copy_process() failed. I do
> > not think this is bad, but Eric seems to disagree with such a change.
> > 
> > But I can't understand why Andrew sees the same problem _after_ this patch!
> >
> > And which patch removed the "put_user(nr, parent_tidptr)" chunk?
> 
> Aha. I am looking at
> 	ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/broken-out/pid-namespaces-allow-cloning-of-new-namespace.patch
> 
> Looks like the original patch was damaged somehow, it doesn't have the
> "put_user(nr, parent_tidptr)" code.
> 

It does have it, except it moved somewhere else.  That would have been me
trying to fix yet another reject storm.  I thought I had that one right. 
Could someone fix it please?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/