linux-kernel - Re: [PATCH] JFS: Bio cleanup: Replace missing return statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071013122853.aafd3c00.randy.dunlap@oracle.com>
Date:	Sat, 13 Oct 2007 12:28:53 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, shaggy@...ux.vnet.ibm.com
Subject: Re: [PATCH] JFS: Bio cleanup: Replace missing return statements

On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote:

> 
> From: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
> 
> commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;"
> statements, rather than changing them to null returns.

Is my git tree mucked up?  It looks to me like it was commit
e30408b2a99cb7b8bf529c7dc2328a19d71894cf  that removed the return 0's.


> Signed-off-by: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
> ---
> Dave sent this under a different cover, but just in case it was missed
> in the middle of the thread, I wanted to make sure it was not missed.
> 
>  fs/jfs/jfs_logmgr.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index ccfd029..15a3974 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
>  
>  		/* wakeup I/O initiator */
>  		LCACHE_WAKEUP(&bp->l_ioevent);
> +
> +		return;
>  	}
>  
>  	/*
> @@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
>  	if (bp->l_flag & lbmDIRECT) {
>  		LCACHE_WAKEUP(&bp->l_ioevent);
>  		LCACHE_UNLOCK(flags);
> +		return;
>  	}
>  
>  	tail = log->wqueue;

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/