linux-kernel - Re: [PATCH] fw-cdev _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47126583.3060803@s5r6.in-berlin.de>
Date:	Sun, 14 Oct 2007 20:52:51 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Al Viro <viro@....linux.org.uk>
CC:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fw-cdev __user annotations

Al Viro wrote:
> --- a/drivers/firewire/fw-cdev.c
> +++ b/drivers/firewire/fw-cdev.c
> @@ -722,10 +722,11 @@ static int ioctl_queue_iso(struct client *client, void *buffer)
>  		buffer_end = 0;
>  	}
>  
> -	if (!access_ok(VERIFY_READ, request->packets, request->size))
> +	p = (struct fw_cdev_iso_packet __user *)u64_to_uptr(request->packets);
> +
> +	if (!access_ok(VERIFY_READ, p, request->size))
>  		return -EFAULT;
>  
> -	p = (struct fw_cdev_iso_packet __user *)u64_to_uptr(request->packets);
>  	end = (void __user *)p + request->size;
>  	count = 0;
>  	while (p < end) {

Acked-by: Stefan Richter <stefanr@...6.in-berlin.de>

I will enqueue it in case Linus doesn't pick it up before my next pull
request.
-- 
Stefan Richter
-=====-=-=== =-=- -===-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/