[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071014210341.GA30029@infradead.org>
Date: Sun, 14 Oct 2007 22:03:41 +0100
From: Christoph Hellwig <hch@...radead.org>
To: Jiri Kosina <jkosina@...e.cz>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remove GPL restriction from set_dumpable()
On Sun, Oct 14, 2007 at 01:04:31PM +0200, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
>
> remove GPL restriction from set_dumpable()
>
> Commit 6c5d5238 introduced a set_dumpable() function that replaced the
> direct access to mm_struct->dumpable. I don't think there is any reason to
> restrict this function to EXPORT_SYMBOL_GPL() -- previously any module
> could modify current->mm->dumpable without any resitrictions, so it makes
> a little sense to turn this into 'internal interface' at once.
>
> There in fact are 3rd party modules that modify the dumpable flag, and
> this patch should fix the situation for them once again (for example
> vmware).
Nack, the just shouldn't do such things at all. I start to get really
sick of patches adding random exports everywhere.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists