linux-kernel - Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47133ABD.8050608@qumranet.com>
Date:	Mon, 15 Oct 2007 12:02:37 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Laurent Vivier <Laurent.Vivier@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time	accounting.

Ingo Molnar wrote:
> * Avi Kivity <avi@...ranet.com> wrote:
>
>   
>> This bit can go; for the external module I can add it back in 
>> external-module-compat.h.  No need to pollute mainline with backward 
>> compatibility stuff.
>>     
>
> hm:
>
> static inline void kvm_guest_enter(void)
> {
>         current->flags |= PF_VCPU;
> }
>
> static inline void kvm_guest_exit(void)
> {
> }
>
> shouldnt PF_VCPU be cleared in kvm_guest_exit()?
>   

IIRC the accounting code clears it, but yes, it may not have been called 
at all, so clearing it here is needed.


-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/