linux-kernel - RocketPort Linux driver errors on module reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87abqk1z3t.fsf@tac.ki.iif.hu>
Date:	Mon, 15 Oct 2007 11:55:18 +0200
From:	Ferenc Wagner <wferi@...f.hu>
To:	linux-kernel@...r.kernel.org
Subject: RocketPort Linux driver errors on module reload

Hi,

A few days ago I sent the enclosed bug report to the address
advertised in Documentation/rocket.txt.  Till now I got no reply.
While they think about it, I decided to air the problem here, too.

In a nutshell, the rocket module doesn't deregister its devices during
removal, they stay in /sys/class/tty causing grief on reinsert and
crippling udev.

Assuming it's an easy fix, can I plea for a patch against 2.6.23?  Or
is there a workaround like manually deregistering the devices?

Thanks,
Feri.

-------------------- Start of forwarded message --------------------
From: Ferenc Wagner <wferi@...f.hu>
To: support@...trol.co.uk
Subject: RocketPort Linux driver errors on module reload
Date: Fri, 12 Oct 2007 00:22:17 +0200
Message-ID: <87fy0hwaue.fsf@....ki.iif.hu>

Hi,

I hope I send this message to the right address...

I experience the following with the 2.09 version of the driver, as
included in vanilla Linux 2.6.23.  If I insert the module, I got some
pretty normal messages, like:

RocketPort device driver module, version 2.09, 12-June-2003
ACPI: PCI Interrupt 0000:01:08.0[A] -> GSI 20 (level, low) -> IRQ 21
Comtrol PCI controller #0 ID 0x802 found in bus:slot:fn 0000:01:08.0 at address d800, 1 AIOP(s) (RocketPort UPCI 8 port w/external I/F)
Installing RocketPort UPCI 8 port w/external I/F, creating /dev/ttyR0 - 7
ACPI: PCI Interrupt 0000:02:06.0[A] -> GSI 24 (level, low) -> IRQ 22
Comtrol PCI controller #1 ID 0x802 found in bus:slot:fn 0000:02:06.0 at address c800, 1 AIOP(s) (RocketPort UPCI 8 port w/external I/F)
Installing RocketPort UPCI 8 port w/external I/F, creating /dev/ttyR8 - 15

However, if I remove the module from the kernel, and then insert it
again, lots of error messages result:

RocketPort device driver module, version 2.09, 12-June-2003
Comtrol PCI controller #0 ID 0x802 found in bus:slot:fn 0000:01:08.0 at address d800, 1 AIOP(s) (RocketPort UPCI 8 port w/external I/F)
Installing RocketPort UPCI 8 port w/external I/F, creating /dev/ttyR0 - 7
kobject_add failed for ttyR0 with -EEXIST, don't try to register things with the same name in the same directory.
 [<c01ccdb4>] kobject_shadow_add+0x156/0x188
 [<c01cd095>] kobject_set_name+0x2b/0x92
 [<c022d022>] device_add+0x87/0x50f
 [<c01cce24>] kobject_init+0x2f/0x3f
 [<c022da2c>] device_create+0x77/0x97
 [<c02154cb>] tty_register_device+0xb5/0xbd
 [<f8a130d3>] init_r_port+0x5f1/0x623 [rocket]
 [<c02409a9>] pci_read+0x29/0x2e
 [<f8b74ff7>] rp_init+0xff7/0x111a [rocket]
 [<c013fd38>] __link_module+0x0/0x1f
 [<c01421de>] sys_init_module+0x1470/0x15a9
 [<c01296a7>] __request_region+0x0/0x80
 [<c0103e12>] sysenter_past_esp+0x6b/0xa1
 =======================
And so on for each device.

However, the card seems to operate all right.  Still, the messages
suggest something isn't quite right and could use some fixing.  Hope
you can find the problem.
-- 
Regards,
Ferenc Wagner

-------------------- End of forwarded message --------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/