lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071015012621.GD10006@agk.fab.redhat.com> Date: Mon, 15 Oct 2007 02:26:21 +0100 From: Alasdair G Kergon <agk@...hat.com> To: Arnd Bergmann <arnd@...db.de> Cc: Linus Torvalds <torvalds@...ux-foundation.org>, dm-devel@...hat.com, linux-kernel@...r.kernel.org, Milan Broz <mbroz@...hat.com>, Guido Guenther <agx@...xcpu.org>, Kevin Corry <kevcorry@...ibm.com>, stable@...nel.org Subject: Re: [2.6.24 PATCH 02/25] dm io:ctl use constant struct size On Sat, Oct 13, 2007 at 12:16:29AM +0200, Arnd Bergmann wrote: > This change seems rather bogus, you're changing the ABI just to work > around a bug in the compat_ioctl layer. Why not just do the compat > code the right way, like the patch below? The underlying ABI is not changing, I hope - the trailing padding in the struct should not affect the processing of the data by dm, and I see no reason to continue maintaining the fiction that the 32-bit and 64-bit ioctls are in some way incompatible with each other when they aren't AFAIK. And yes, a follow-up patch can clean up our use of the compatibility mechanism, going a little bit further than the patch you attached, I hope. Alasdair -- agk@...hat.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists