[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200710151251.12981.borntraeger@de.ibm.com>
Date: Mon, 15 Oct 2007 12:51:12 +0200
From: Christian Borntraeger <borntraeger@...ibm.com>
To: Laurent Vivier <Laurent.Vivier@...l.net>
Cc: Ingo Molnar <mingo@...e.hu>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting
Am Montag, 10. September 2007 schrieb Laurent Vivier:
> The aim of these four patches is to introduce Virtual Machine time accounting.
I would move this line
if (p->flags & PF_VCPU) {
account_guest_time(p, cputime);
------> p->flags &= ~PF_VCPU; <---------
return;
}
into kvm_guest_exit. Otherwise a guest that is running very long in
guest context would only get the first tick accounted as guest time, no?
Besides that, this looks good and should work for kvm on s390 as well.
Thanks Laurent.
Christian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists