linux-kernel - Re: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4713815A.3020300@lwfinger.net>
Date:	Mon, 15 Oct 2007 10:03:54 -0500
From:	Larry Finger <larry.finger@...inger.net>
To:	WANG Cong <xiyou.wangcong@...il.com>
CC:	Adrian Bunk <bunk@...nel.org>, mb@...sch.de,
	John Linville <linville@...driver.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize
 the	correct return value

WANG Cong wrote:
> Initialize "err" in drivers/net/wireless/b43legacy/main.c::b43legacy_start()
> in case of returning an uninitialized value.
> 
> From: Adrian Bunk <bunk@...nel.org>
> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
> 
> ---
>  drivers/net/wireless/b43/main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
> ===================================================================
> --- linux-2.6.23-mm1.orig/drivers/net/wireless/b43legacy/main.c
> +++ linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
> @@ -3306,7 +3306,7 @@ static int b43legacy_start(struct ieee80
>  	struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
>  	struct b43legacy_wldev *dev = wl->current_dev;
>  	int did_init = 0;
> -	int err;
> +	int err = 0;
>  
>  	mutex_lock(&wl->mutex);

I sent the equivalent patch to John Linville yesterday.

Larry

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/