[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071015154031.GA30754@redhat.com>
Date: Mon, 15 Oct 2007 11:40:31 -0400
From: Dave Jones <davej@...hat.com>
To: Andy Whitcroft <apw@...dowen.org>
Cc: Mark Langsdorf <mark.langsdorf@....com>,
Andi Kleen <andi@...stfloor.org>, cpufreq@...ts.linux.org.uk,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH][try 2] architectural pstate driver for powernow-k8
On Thu, Oct 11, 2007 at 08:59:58AM +0100, Andy Whitcroft wrote:
> > /* get fid did for hardware pstate transition */
> > pstate = index & HW_PSTATE_MASK;
> > - if (pstate > MAX_HW_PSTATE)
> > + if (pstate > data->max_hw_pstate);
> > return 0;
>
> checkpatch picked up this dodgy if. I suspect that the ';' is wrong
> from the context.
Indeed. Mark/Andreas, want to send me a new patch against latest
Linus HEAD ? I didn't apply the old one yet, as it conflicted with
the changes already queued for merging.
Thanks,
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists