[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071015203247.GA14279@redhat.com>
Date: Mon, 15 Oct 2007 16:32:47 -0400
From: Dave Jones <davej@...hat.com>
To: Mark Langsdorf <mark.langsdorf@....com>
Cc: Andy Whitcroft <apw@...dowen.org>,
Andi Kleen <andi@...stfloor.org>, cpufreq@...ts.linux.org.uk,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH][try 3] architectural pstate driver for powernow-k8
On Mon, Oct 15, 2007 at 11:23:45AM -0500, Mark Langsdorf wrote:
> On Monday 15 October 2007 10:40, Dave Jones wrote:
> > On Thu, Oct 11, 2007 at 08:59:58AM +0100, Andy Whitcroft wrote:
> >
> > > > /* get fid did for hardware pstate transition */
> > > > pstate = index & HW_PSTATE_MASK;
> > > > - if (pstate > MAX_HW_PSTATE)
> > > > + if (pstate > data->max_hw_pstate);
> > > > return 0;
> > >
> > > checkpatch picked up this dodgy if. I suspect that the ';' is wrong
> > > from the context.
> >
> > Indeed. Mark/Andreas, want to send me a new patch against latest
> > Linus HEAD ? I didn't apply the old one yet, as it conflicted with
> > the changes already queued for merging.
>
> This is against -git7. I should think that's close enough.
So close!
arch/x86/kernel/cpu/cpufreq/powernow-k8.c: In function ‘powernowk8_target’:
arch/x86/kernel/cpu/cpufreq/powernow-k8.c:1054: error: ‘struct powernow_k8_data’ has no member named ‘currdid’
make[1]: *** [arch/x86/kernel/cpu/cpufreq/powernow-k8.o] Error 1
make: *** [arch/x86/kernel/cpu/cpufreq/powernow-k8.o] Error 2
Missed one of the conversions?
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists