linux-kernel - Re: [PATCH 1/3] Misc: phantom, synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071015162344.dca7023c.akpm@linux-foundation.org>
Date:	Mon, 15 Oct 2007 16:23:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH 1/3] Misc: phantom, synchronize_irq() on suspend

On Mon, 15 Oct 2007 09:32:28 -0700
Jiri Slaby <jirislaby@...il.com> wrote:

> phantom, synchronize_irq() on suspend
> 
> Wait after disabling device's interrupt until the handler finishes its
> work if still in progress.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> 
> ---
> commit 7e792ef384190b517f2fb27cd0237fa30dbe0775
> tree 17b15e5ab7c90eef0e7ae57e532839e81b831d58
> parent 5c008a5651ee92ebe020dd5108a66a7db74fe41d
> author Jiri Slaby <jirislaby@...il.com> Mon, 15 Oct 2007 15:52:21 +0200
> committer Jiri Slaby <jirislaby@...il.com> Mon, 15 Oct 2007 15:52:21 +0200
> 
>  drivers/misc/phantom.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
> index 5108b7c..6e61a79 100644
> --- a/drivers/misc/phantom.c
> +++ b/drivers/misc/phantom.c
> @@ -378,6 +378,8 @@ static int phantom_suspend(struct pci_dev *pdev, pm_message_t state)
>  	iowrite32(0, dev->caddr + PHN_IRQCTL);
>  	ioread32(dev->caddr + PHN_IRQCTL); /* PCI posting */
>  
> +	synchronize_irq(pdev->irq);
> +
>  	return 0;
>  }
>  

What inspired this change?  Some bug report, or does it just seem the right
thing to do?

Would it be logical to do this operation from the PCI core somewhere, on
behalf of all PCI drivers?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/